Skip to content

Set the user-agent in the release name tool #9016

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 10, 2025
Merged

Set the user-agent in the release name tool #9016

merged 1 commit into from
Sep 10, 2025

Conversation

afrittoli
Copy link
Member

Changes

Wikimedia requires an user-agent being set, so adding one to the tool that fetches the robot page for release names.

/kind misc

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • Has Docs if any changes are user facing, including updates to minimum requirements e.g. Kubernetes version bumps
  • Has Tests included if any functionality added or changed
  • pre-commit Passed
  • Follows the commit message standard
  • Meets the Tekton contributor standards (including functionality, content, code)
  • Has a kind label. You can add one by adding a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
  • Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings). See some examples of good release notes.
  • Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes

NONE

@afrittoli
Set the user-agent in the release name tool
946a35f 
Wikimedia requires an user-agent being set, so adding one to
the tool that fetches the robot page for release names.

Signed-off-by: Andrea Frittoli <[email protected]>
@tekton-robot tekton-robot added release-note-none Denotes a PR that doesnt merit a release note. kind/misc Categorizes issue or PR as a miscellaneuous one. labels Sep 4, 2025
@tekton-robot tekton-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Sep 4, 2025
@afrittoli
Copy link
Member Author

/retest

1 similar comment
@afrittoli
Copy link
Member Author

/retest

@tekton-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: waveywaves

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 8, 2025
@waveywaves
Copy link
Member

This is not a major change and is pretty straightforward, this PR just adds a header to the request being sent to wikimedia according to their guidelines.

@waveywaves waveywaves added the lgtm Indicates that a PR is ready to be merged. label Sep 10, 2025
@tekton-robot tekton-robot merged commit 87c989e into tektoncd:main Sep 10, 2025
64 of 69 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@waveywaves waveywaves waveywaves approved these changes

@dibyom dibyom Awaiting requested review from dibyom

@pritidesai pritidesai Awaiting requested review from pritidesai

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/misc Categorizes issue or PR as a miscellaneuous one. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesnt merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
Tekton Community Roadmap
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@afrittoli @tekton-robot @waveywaves